close
The Wayback Machine - https://web.archive.org/web/20211022003809/https://github.com/python/cpython/pull/990
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29979: rewrite cgi.parse_multipart() #990

Closed
wants to merge 33 commits into from
Closed

bpo-29979: rewrite cgi.parse_multipart() #990

wants to merge 33 commits into from

Conversation

@PierreQuentel
Copy link
Contributor

@PierreQuentel PierreQuentel commented Apr 4, 2017

The Pull Request simplifies the code of cgi.parse_multipart() by reusing the FieldStorage class, and makes it consistent with FieldStorage results : the values for non-file fields becomes a list of strings, instead of a list of bytes.
Pierre Quentel and others added 30 commits Feb 25, 2017
Support If-Modified-Since HTTP headers, return 304 response if file w…
20cc898 
…as not modified
Fix bug in datetime comparisons. Ignore If-Modified-Since if If-None-…
f1d8a48 
…Match is present. Add tests.
Update Misc/NEWS and What's New
c4403ec
Fix typo
3225080
Use parsedate_to_datetime to extract datetime from If-Modified-Since,…
415e4af 
… check that it's a valid HTTP date with timezone set to UTC.
Change computing of dates used to test browser cache
8595735
Remove microseconds from time of last modification with .replace(micr…
2be2f8c 
…osecond=0) instead of int()
Put os.fstat() call inside the try block ; handle obsolete HTTP date …
c3337f4 
…format ; ignore ill-formed values in If-Modified-Since header.
Restore alphabetical order in section Improved Modules
143e1e9
Store last modification date in setUp ; split browser cache tests in …
42edfe3 
…several methods ; add a test for Last-Modified header.
@PierreQuentel
Specify the exceptions to catch in parsedate_to_datetime
1e68be9
@PierreQuentel
Use except/else for parsedate_to_datetime exception handling
fc20596
Restore blank line
9436e45
Put imports in alphabetical order. Change version to 0.7.
708ff03
Presentation changes.
6a58894
Change order of imports.
db46671
Update Misc/NEWS (conflict)
41f74ef
@PierreQuentel
Merge branch 'master' into master
204c503
@PierreQuentel
Merge branch 'master' into master
e2fee49
Restore version number 0.6
6dadf6e
Replace "datetime" by "time"
c389bf6
Merge branch 'master' of https://github.com/PierreQuentel/cpython
3cc4f6d
Proposal for an update of the http.server module documentation
294e164
@PierreQuentel
Merge branch 'master' into master
6c5ba39
@PierreQuentel
Merge branch 'master' into master
1e0f3e3
@serhiy-storchaka
Merge branch 'master' into master
2503add
@PierreQuentel
Merge branch 'master' into master
36a8e2a
Add a "Changed in version 3.7" comment
c8b108f
Merge branch 'master' of https://github.com/PierreQuentel/cpython
bd91346
@PierreQuentel
Merge branch 'master' into master
d3238d2
Pierre Quentel added 3 commits Apr 1, 2017
Remove trailing whitespaces
16f9e11
Merge branch 'master' of https://github.com/PierreQuentel/cpython
c669909
Rewrite cgi.parse_multipart()
815f885
@mention-bot
Copy link

@mention-bot mention-bot commented Apr 4, 2017

@PierreQuentel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhettinger, @orsenthil and @collinw to be potential reviewers.

@PierreQuentel
Copy link
Contributor Author

@PierreQuentel PierreQuentel commented Apr 4, 2017

Sorry, I'm not using the correct version of the Github master repo. I close this PR and will open another one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@PierreQuentel @mention-bot @the-knights-who-say-ni @serhiy-storchaka