Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable #1887
Conversation
This simplifies the reconfiguration of standard streams as it can now be done in-place.
|
@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @birkenfeld to be potential reviewers. |
pitrou
changed the title
|
The AppVeyor failure is unrelated. |
|
so what happens when I set |
| @@ -908,6 +908,16 @@ Text I/O | |||
|
|
|||
| Whether line buffering is enabled. | |||
benjaminp
Jun 1, 2017
Contributor
should also say that writing to it flushes the stream
should also say that writing to it flushes the stream
| .. attribute:: write_through | ||
|
|
||
| Whether writes are passed immediately to the underlying binary | ||
| buffer. This argument is writable. |
benjaminp
Jun 1, 2017
Contributor
ditto
ditto
|
#1922 is now preferred. |
Same as before: |
|
Superseded by #1922. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This simplifies the reconfiguration of standard streams as it can now be done in-place.