Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Log fewer spurious CT submission errors. #3447
Conversation
With the CT policy changes, we cancel any outstanding requests in a group once we've gotten a successful response from any log in that group. That means various function calls will return early with an error code indicating cancellation. We want to avoid logging such error codes, because they were not really errors, they were intentional. This change introduces a small utility package called "canceled", which checks for both context.Canceled and the gRPC return code indicating cancelled.
|
Also, as an FYI: google/certificate-transparency-go#151 |
|
|
| results <- result{sct: sct, err: err} | ||
| }(g) | ||
| if err != nil { | ||
| results <- result{err: fmt.Errorf("CT log group %d: %s", i, err)} |
rolandshoemaker
Feb 16, 2018
Contributor
So this is slightly confusing, and will end up requiring a person to go back to the config to figure out which group is actually being talked about. Probably not required to be done in this PR but I think we should actually turn the group description into a struct so that it can have actual name etc.
So this is slightly confusing, and will end up requiring a person to go back to the config to figure out which group is actually being talked about. Probably not required to be done in this PR but I think we should actually turn the group description into a struct so that it can have actual name etc.
|
Looks good, one comment but I think that should actually be done in a follow up with a few other things, so approved. |
With the CT policy changes, we cancel any outstanding requests in a
group once we've gotten a successful response from any log in that
group. That means various function calls will return early with an error
code indicating cancellation. We want to avoid logging such error codes,
because they were not really errors, they were intentional.
This change introduces a small utility package called "canceled", which
checks for both context.Canceled and the gRPC return code indicating
cancelled.