Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Provide formatting logger functions. #3699
Merged
Conversation
4a6f656c
force-pushed the
4a6f656c:loggerfmt
branch
2 times, most recently
from
2076aa3
to
adebfd9
A very large number of the logger calls are of the form log.Function(fmt.Sprintf(...)). Rather than sprinkling fmt.Sprintf at every logger call site, provide formatting versions of the logger functions and call these directly with the format and arguments. While here remove some unnecessary trailing newlines and calls to String/Error.
rolandshoemaker
merged commit 8ebdfc6
into
letsencrypt:master
1 check passed
1 check passed
4a6f656c
added a commit
to 4a6f656c/boulder
that referenced
this pull request
May 11, 2018
A very large number of the logger calls are of the form log.Function(fmt.Sprintf(...)). Rather than sprinkling fmt.Sprintf at every logger call site, provide formatting versions of the logger functions and call these directly with the format and arguments. While here remove some unnecessary trailing newlines and calls to String/Error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A very large number of the logger calls are of the form log.Function(fmt.Sprintf(...)).
Rather than sprinkling fmt.Sprintf at every logger call site, provide formatting versions
of the logger functions and call these directly with the format and arguments.
While here remove some unnecessary trailing newlines and calls to String/Error.