close
The Wayback Machine - https://web.archive.org/web/20201114121434/https://github.com/letsencrypt/boulder/pull/4252
Skip to content

/ boulder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFE2: Implement badRevocationReason problem type. #4252

Merged
merged 4 commits into from Jun 6, 2019
Merged

WFE2: Implement badRevocationReason problem type. #4252

merged 4 commits into from Jun 6, 2019

Conversation

@cpu
Copy link
Contributor

@cpu cpu commented Jun 6, 2019 •
edited

Previously we were returning a Malformed problem type when rejecting a revocation request for containing an invalid revocation reason code. RFC 8555 Section 7.6 mandates the use of the badRevocationReason problem type for this and encourages including the allowed reasons in the problem detail:

The server MAY disallow a subset of reasonCodes from being used by the user. If a request contains a disallowed reasonCode, then the server MUST reject it with the error type "urn:ietf:params:acme:error:badRevocationReason". The problem document detail SHOULD indicate which reasonCodes are allowed.

Prev response:

{
  "type": "urn:ietf:params:acme:error:malformed",
  "detail":  "unsupported revocation reason code provided",
  "status": 400
}

Updated response:

{
  "type": "urn:ietf:params:acme:error:badRevocationReason",
  "detail": "unsupported revocation reason code provided: cACompromise (2). Supported reasons: unspecified (0), keyCompromise (1), affiliationChanged (3), superseded (4), cessationOfOperation (5)",
  "status": 400
}

Resolves #4250
Daniel
WFE2: Implement badRevocationReason problem type.
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
5ada205 
Previously we were returning a Malformed problem type where RFC 8555
mandates the use of badRevocationReason and encourages including the
allowed reasons in the problem detail.
@cpu cpu requested a review from letsencrypt/boulder-developers as a code owner Jun 6, 2019
@cpu cpu self-assigned this Jun 6, 2019
Daniel added 2 commits Jun 6, 2019
Daniel
probs: fix TestProblemDetailsToStatusCode for badRevocationReason
Unverified
No user is associated with the committer email.
Learn about signing commits
b9284b8
Daniel
wfe2: improve bad revocation reason error message.
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
9b21ed7 
Tweaked to include both the string and numeric form of the allowed
reason codes. Tweaked to include the string and numeric form of the
rejected reason code.
@cpu cpu mentioned this pull request Jun 6, 2019
Closed
@jsha
jsha reviewed Jun 6, 2019
View changes
@rolandshoemaker
rolandshoemaker reviewed Jun 6, 2019
View changes
revocation/reasons.go Outdated Show resolved Hide resolved
Daniel
review: simplify UserAllowedReasonsMessage.
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
5353688
@rolandshoemaker
rolandshoemaker approved these changes Jun 6, 2019
View changes
@jsha
jsha approved these changes Jun 6, 2019
View changes
@cpu cpu merged commit 584702b into master Jun 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cpu cpu deleted the cpu-revocation-reason-probtype branch Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha

@rolandshoemaker rolandshoemaker

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

wrong error type for unsupported revocation reason
3 participants
@cpu @jsha @rolandshoemaker
You can’t perform that action at this time.