close
The Wayback Machine - https://web.archive.org/web/20201118014330/https://github.com/WordPress/better-code-editing/pull/86
Skip to content
This repository has been archived by the owner. It is now read-only.

Improve frequency for when linting error notifications are shown #86

Merged
merged 8 commits into from Sep 8, 2017

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Sep 8, 2017

  • Only show “can't save” error notifications when focus is removed from editor so that error notices don't distract when typing.
  • Remove empty-rules CSSLint rule and error indicator for trailing whitespace.
  • Prevent hitting Esc from collapsing the widget control.
  • Ensure CodeMirror editor for Additional CSS has bidirectional syncing.
  • Refactor code to reduce duplication and improve API.

Fixes #13.

@westonruter westonruter force-pushed the fix/notices branch from 43634bf to 9040961 Sep 8, 2017
@westonruter westonruter force-pushed the fix/notices branch from 9040961 to ca184f7 Sep 8, 2017
@westonruter westonruter merged commit 8760082 into master Sep 8, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@westonruter westonruter deleted the fix/notices branch Sep 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.