close
The Wayback Machine - https://web.archive.org/web/20220721135407/https://github.com/WordPress/performance/pull/429
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PERFLAB_PLUGIN_DIR_PATH constant for plugin_dir_path() #429

Merged
merged 2 commits into from Jul 20, 2022
Merged

Add PERFLAB_PLUGIN_DIR_PATH constant for plugin_dir_path() #429

merged 2 commits into from Jul 20, 2022

Conversation

mukeshpanchal27
Copy link
Contributor

@mukeshpanchal27 mukeshpanchal27 commented Jul 15, 2022

Summary

Fixes #428

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement Infrastructure no milestone labels Jul 15, 2022
@mukeshpanchal27 mukeshpanchal27 requested review from felixarntz, jjgrainger and mehulkaklotar and removed request for felixarntz and jjgrainger Jul 15, 2022
mehulkaklotar
mehulkaklotar reviewed Jul 15, 2022
View changes
load.php Outdated Show resolved Hide resolved
@bethanylang bethanylang added this to Backlog in Infrastructure via automation Jul 15, 2022
@bethanylang bethanylang moved this from Backlog to Review in Infrastructure Jul 15, 2022
@felixarntz felixarntz added this to the 1.4.0 milestone Jul 15, 2022
@felixarntz felixarntz removed the no milestone label Jul 15, 2022
mehulkaklotar
mehulkaklotar approved these changes Jul 20, 2022
View changes
Copy link
Member

@mehulkaklotar mehulkaklotar left a comment

🚀

felixarntz
felixarntz approved these changes Jul 20, 2022
View changes
Copy link
Member

@felixarntz felixarntz left a comment

@mukeshpanchal27 Great, thanks!

@felixarntz felixarntz merged commit bfa6d75 into trunk Jul 20, 2022
5 checks passed
Infrastructure automation moved this from Review to Done Jul 20, 2022
@felixarntz felixarntz deleted the fix/428-add-constant branch Jul 20, 2022
@felixarntz felixarntz changed the title Add constant for plugin_dir_path Add PERFLAB_PLUGIN_DIR_PATH constant for plugin_dir_path() Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz

@mehulkaklotar mehulkaklotar

@jjgrainger jjgrainger

@peterwilsoncc peterwilsoncc

Assignees
No one assigned
Labels
Infrastructure [Type] Enhancement
Projects
Infrastructure
Done
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Use constant for plugin_dir_path
3 participants
@mukeshpanchal27 @felixarntz @mehulkaklotar