close
The Wayback Machine - https://web.archive.org/web/20220720233235/https://github.com/WordPress/performance/pull/200
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always recommend object cache on multisite #200

Merged
merged 4 commits into from Mar 1, 2022
Merged

Always recommend object cache on multisite #200

merged 4 commits into from Mar 1, 2022

Conversation

tillkruss
Copy link
Member

@tillkruss tillkruss commented Mar 1, 2022

Summary

This is a followup to #111 and resolves #161.

A @spacedmonkey suggested, multisite greatly benefits from object caching, due to the extra queries to bootstrap WordPress.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@tillkruss tillkruss added [Type] Enhancement [Focus] Object Cache labels Mar 1, 2022
@tillkruss tillkruss added this to the 1.0.0-beta.1 milestone Mar 1, 2022
@tillkruss tillkruss requested a review from felixarntz Mar 1, 2022
@tillkruss tillkruss requested a review from spacedmonkey as a code owner Mar 1, 2022
@tillkruss tillkruss self-assigned this Mar 1, 2022
@tillkruss tillkruss added this to Backlog in [Focus] Object Cache via automation Mar 1, 2022
@tillkruss tillkruss changed the title always recommend object cache on multisite Always recommend object cache on multisite Mar 1, 2022
Copy link
Member

@felixarntz felixarntz left a comment

@tillkruss LGTM, except for one thing that is more of an oversight from #111.

@tillkruss tillkruss requested a review from felixarntz Mar 1, 2022
Copy link
Member

@felixarntz felixarntz left a comment

🎉

mitogh
mitogh approved these changes Mar 1, 2022
@felixarntz felixarntz merged commit 89a354d into trunk Mar 1, 2022
5 checks passed
[Focus] Object Cache automation moved this from Backlog to Done Mar 1, 2022
@felixarntz felixarntz added the [Module] Persistent Object Cache label Mar 4, 2022
@tillkruss tillkruss deleted the tillkruss-161 branch Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Object Cache [Module] Persistent Object Cache [Type] Enhancement
Development

Successfully merging this pull request may close these issues.

3 participants