use sortorder library for sorting network list output

[adshmh]

- What I did
Use sortorder lib for sorting the output of network list command

- How I did it
Used NaturalLess for ordering the output, consistent with other commands

- How to verify it

• create 3 networks: net-1, net-2, net-10
• run docker network list --format '{{ .Name }}'
• output:

...
net-1
net-10
net-2
...

• output after the changes made by this PR:

...
net-1
net-2
net-10
...

- Description for the changelog
network list command uses sortorder lib to sort the output

- A picture of a cute animal (not mandatory but encouraged)

[codecov-io]

Codecov Report

Merging #1266 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1266   +/-   ##
=======================================
  Coverage   54.29%   54.29%           
=======================================
  Files         268      268           
  Lines       17855    17855           
=======================================
  Hits         9695     9695           
  Misses       7550     7550           
  Partials      610      610

[adshmh]

There are still a few more commands, e.g. trust inspect and volume list where direct comparison is used. I can update the PR to modify those as well if such a change is desirable.

[silvin-lubecki]

Thank you @adshmh ! Yes please follow with the other commands in this very PR. Otherwise LGTM 😄

[thaJeztah]

LGTM, thanks!

[thaJeztah]

oh! sorry, missed the other comment; yes including other output in this PR would be good (but also fine with going ahead with just this one 😅)

[adshmh]

Thank you for the reviews. I have updated the PR.

There are 2 remaining instances of direct comparison in the trust package, in cli/command/trust/inspect.go, but one is on canonical base role names, i.e. not user-defined. The second one:

cli/cli/command/trust/inspect.go

Lines 66 to 89 in 1d04f7d

	func getRepoTrustInfo(cli command.Cli, remote string) ([]byte, error) {
	signatureRows, adminRolesWithSigs, delegationRoles, err := lookupTrustInfo(cli, remote)
	if err != nil {
	return []byte{}, err
	}
	// process the signatures to include repo admin if signed by the base targets role
	for idx, sig := range signatureRows {
	if len(sig.Signers) == 0 {
	signatureRows[idx].Signers = append(sig.Signers, releasedRoleName)
	}
	}
	signerList, adminList := []trustSigner{}, []trustSigner{}
	signerRoleToKeyIDs := getDelegationRoleToKeyMap(delegationRoles)
	for signerName, signerKeys := range signerRoleToKeyIDs {
	signerKeyList := []trustKey{}
	for _, keyID := range signerKeys {
	signerKeyList = append(signerKeyList, trustKey{ID: keyID})
	}
	signerList = append(signerList, trustSigner{signerName, signerKeyList})
	}
	sort.Slice(signerList, func(i, j int) bool { return signerList[i].Name > signerList[j].Name })

I think testing the above for order would require adding some mocking code to allow adding custom role names to a notary repository (perhaps that can be added at some point when required by more test cases on trust package) or, alternatively, adding another predefined notary repository.

[silvin-lubecki]

LGTM (with a small nit), thank you @adshmh !!

[silvin-lubecki]

nit: releasesRole := data.DelegationRole{BaseRole: data.BaseRole{Name: trust.ReleasesRole}}

[adshmh]

Thank you for the review. Seems the PR was merged before I modify this.

[thaJeztah]

No worries; I looked at the comment, and thought it to be not relevant enough to update before merging 🤗

[silvin-lubecki]

@thaJeztah PTAL

[thaJeztah]

LGTM, thanks!

[thaJeztah]

nit; might want to swap A, B and C in this list, so that it's more clear that the list is sorted by signer, not keys