close
The Wayback Machine - https://web.archive.org/web/20251014201352/https://github.com/docker/docker-ce-packaging/pull/276
Skip to content

[18.09] Add docker.socket requirement for docker.service #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

[18.09] Add docker.socket requirement for docker.service #276

merged 1 commit into from
Dec 3, 2018

Conversation

andrewhsu
Copy link
Contributor

@andrewhsu andrewhsu commented Dec 3, 2018 •
edited
Loading

backport of #275

$ git cherry-pick -s -x 88885d1
[sock 93f125a] Add docker.socket requirement for docker.service
 Author: Eli Uriegas <eli.uriegas@docker.com>
 Date: Mon Dec 3 19:14:10 2018 +0000
 1 file changed, 1 insertion(+)

@seemethere @andrewhsu
Add docker.socket requirement for docker.service
93f125a 
Without this the docker.socket would not start by default when starting
the docker.service leading to failures to start.

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
(cherry picked from commit 88885d1)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu added this to the 18.09.1 milestone Dec 3, 2018
@andrewhsu andrewhsu requested a review from a team December 3, 2018 19:44
@seemethere seemethere mentioned this pull request Dec 3, 2018
Closed
corbin-coleman
corbin-coleman approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@corbin-coleman corbin-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@docker-unir docker-unir bot merged commit be8c06f into docker:18.09 Dec 3, 2018
@seemethere seemethere deleted the sock branch December 3, 2018 19:45
@bzh-bzh bzh-bzh mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@seemethere seemethere seemethere approved these changes

@corbin-coleman corbin-coleman corbin-coleman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.09.1

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewhsu @seemethere @corbin-coleman