close
Skip to content

docs(autosde): freeze the chat session row's line count - #2512

Merged
CrysisDeu merged 1 commit into
mainfrom
docs/autosde-session-row-density
Aug 10, 2026
Merged

docs(autosde): freeze the chat session row's line count#2512
CrysisDeu merged 1 commit into
mainfrom
docs/autosde-session-row-density

Conversation

@CrysisDeu

Copy link
Copy Markdown
Collaborator

What

Adds a blocking frontend AutoSDE rule, session-row-fixed-height: a chat session list item has a fixed set of stacked lines, and new per-session metadata may not add another one.

Why

The session list is the dashboard's primary navigation surface, and its only real budget is how many sessions fit above the fold. An extra line is paid by every session in the list, forever, so one constant field can be read without hovering — and the fields that keep getting proposed (project directory, branch, model, workspace) do not change for the life of the session, i.e. exactly what a user does not re-read on every scan. The lines that exist are earned: mutually exclusive turn state, or they disappear when empty.

The rule

Permitted lines: agent/meta, title, ONE status line (ternary chain), source-link chips, tag chips.

Escalation order for a new field:

  1. inline on the agent/meta line, directly after the agent name (glyph or compact truncating chip with a title tooltip) — this is where a project directory belongs;
  2. folded into an existing line as trailing detail (the goalLoopDetail pattern);
  3. row tooltip, SessionActionsMenu, or the detail/flyout surface.

Widening the row is explicitly not an alternative: the sidebar width is user-controlled and the list must not scroll horizontally.

Scoped to ChatSidebar.tsx, chat/SessionFlyout.tsx, components/SessionGridView.tsx.

Verification

YAML parses; 11 rules load, new id present, blocking: true. Docs-only change — no code touched.

The session list is the dashboard's primary navigation surface and its only
real budget is how many sessions fit above the fold. Every stacked line added
to a row is paid by every session in the list, and the fields that keep getting
proposed for it (project directory, branch, model, workspace) are constant for
the life of the session — exactly the information a user does not re-read on
every scan.

Adds a blocking frontend rule, session-row-fixed-height, that enumerates the
five permitted lines (agent/meta, title, one mutually-exclusive status line,
source-link chips, tag chips) and gives the escalation order for a new field:
inline on the agent/meta line after the agent name, then folded into an existing
line as trailing detail, then tooltip or actions menu. Widening the row is
explicitly not an alternative — the sidebar width is user-controlled and the
list must not scroll horizontally.

Scoped to the three surfaces that render a session row: ChatSidebar,
SessionFlyout, SessionGridView.
@CrysisDeu
CrysisDeu requested a review from a team as a code owner August 10, 2026 08:27
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 93d6518086bffa6f671039fa2f02f9bc9229506f — this comment is updated in place on each push.

Review details

The diff is a pure addition of one new blocking rule to website/AUTOSDE.yaml, with no deletions to existing rules (the only - line is the diff header). Adding or tightening a rule is explicitly not a finding, and no existing blocking: true rule is weakened. The YAML is well-formed and the rule's file-patterns and guidance are internally consistent.

No findings.

[OPUS-REVIEWED] 93d6518

Verdict parsed from the review's SHA-scoped output markers for commit 93d6518086bffa6f671039fa2f02f9bc9229506f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 93d6518086bffa6f671039fa2f02f9bc9229506f: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

Advisory UX-level review of 93d6518086bffa6f671039fa2f02f9bc9229506f — updated in place on each push; does not block merge.

The diff is a single addition to website/AUTOSDE.yaml — a blocking lint rule freezing the session row's line count. No component, string, or rendered pixel changes; nothing a user experiences ships in this PR. The rule itself encodes density discipline for the dashboard's sovereign surface, which is the right posture.

UX-Verdict: PASS

No user-facing change ships — a lint rule freezing session-row density, and its escalation ladder (inline → fold → tooltip/menu) is sound UX guidance.

[UX-REVIEWED] 93d6518

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 93d6518086bffa6f671039fa2f02f9bc9229506f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 93d6518

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 93d6518086bffa6f671039fa2f02f9bc9229506f: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Advisory design-level review of 93d6518086bffa6f671039fa2f02f9bc9229506f — updated in place on each push; does not block merge.

Design-Verdict: PASS

Sound design-freeze rule: encodes a real, recurring density regression at the layer that catches it, and matches the code it describes.

Suggestions

  • The rule enumerates the current ternary-chain branch order and glyph inventory verbatim; adding a permitted status branch (allowed — still one line) makes a blocking rule's text stale and invites false flags. State the invariant (one status line, mutually exclusive branches) and let the code own the branch list.
  • SessionFlyout.tsx is both in file-patterns and named as the sanctioned overflow surface ("the session detail/flyout surface"); a line clarifying the rule governs the flyout's row rendering, not fields added to the flyout body, would prevent the automated reviewer from blocking the escape hatch it recommends.

[DESIGN-REVIEWED] 93d6518

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Aug 10, 2026
@CrysisDeu
CrysisDeu merged commit a0f2a5e into main Aug 10, 2026
74 of 79 checks passed
@CrysisDeu
CrysisDeu deleted the docs/autosde-session-row-density branch August 10, 2026 17:46
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant