Storybook: Fix emotion/is-prop-valid warning#68202
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in e44b61a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12434441860
|
manzoorwanijk
added a commit
that referenced
this pull request
May 26, 2026
* Move @emotion deps out of root package.json Move @emotion/is-prop-valid, @emotion/native, @emotion/react, and @emotion/styled out of the root `package.json` and into the workspaces that actually consume them, making dependency relationships explicit instead of relying on root hoisting. - `packages/components`: add `@emotion/native` (consumed by `src/text/index.native.js` and `src/text/styles/emotion-css.native.js`, previously a phantom dependency on the root). - `storybook`: add `@emotion/react`, `@emotion/styled` (consumed by `main.ts`, decorators, and stories), and `@emotion/is-prop-valid` (declared to silence the framer-motion warning per #68202). - Root `package.json`: remove the four entries above. * Components: Changelog entry for @emotion/native direct dependency Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR resolves the last warning we see on load in Storybook (after #68198 and #68199 tackled the other five).
Why?
Just fixing a warning.
How?
Adding
emotion/is-prop-validas a specific dev dependency because currently it's declared as an optional peer dependency:https://github.com/motiondivision/motion/blob/6ddb3e79685653f18a863f64f76c3fb5fade1903/packages/framer-motion/package.json#L94-L102
Testing Instructions
package-lock.json, just shifting existing ones around.Testing Instructions for Keyboard
Same
Screenshots or screencast