Acceptance test workflow#732
Merged
scotchneat merged 3 commits intoOct 27, 2021
Merged
Conversation
andrewsomething
approved these changes
Oct 27, 2021
andrewsomething
left a comment
Member
There was a problem hiding this comment.
👍 LGTM!
As you changed the name of the test job, I think you'll need to go into settings and update the branch protection rules to be able to merge this.
Contributor
Author
|
👍🏽 Done |
Member
|
This shouldn't block this, but we should consider running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the test.yml workflow to include a job to run the acceptance tests.
The
acceptancejob uses a deployment environment in the github repo which has been configured with the appropriate secrets. It's also configured to require reviews by the @digitalocean/api-cli team before the job will run. Finally, the job hascontinue-on-error: true. The idea is to allow this job to be added as a check to PRs but isn't required to succeed for the PR to be merged.The
make testaccstep sets the env varTESTARGS=-parallel 20but the entire suite still takes over 30 minutes to complete.