close
Skip to content

feat: Add findLastIndex for Array and TypedArray (Stage 3) - #1981

Merged
MaxGraey merged 6 commits into
AssemblyScript:mainfrom
MaxGraey:find-last-index
Jul 23, 2021
Merged

feat: Add findLastIndex for Array and TypedArray (Stage 3)#1981
MaxGraey merged 6 commits into
AssemblyScript:mainfrom
MaxGraey:find-last-index

Conversation

@MaxGraey

@MaxGraey MaxGraey commented Jul 14, 2021

Copy link
Copy Markdown
Member

Also some refactoring in Array.ts and TypedArray.ts for consistency

  • I've read the contributing guidelines

@MaxGraey
MaxGraey marked this pull request as ready for review July 14, 2021 10:27
@MaxGraey
MaxGraey requested a review from dcodeIO July 14, 2021 10:27
Comment thread std/portable/index.d.ts
@MaxGraey

MaxGraey commented Jul 14, 2021

Copy link
Copy Markdown
Member Author

btw we have a problem with unavailable nightly build again

@dcodeIO

dcodeIO commented Jul 14, 2021

Copy link
Copy Markdown
Member

It sometimes becomes available a bit later, may be that it just hasn't finished the build yet. Let's see :)

@MaxGraey

Copy link
Copy Markdown
Member Author

yeah

@MaxGraey
MaxGraey merged commit a0307d8 into AssemblyScript:main Jul 23, 2021
@MaxGraey
MaxGraey deleted the find-last-index branch July 23, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants