fix: Make warning 232 pedantic - #1986
Conversation
Because of tree shaking unused methods or class aren't compiled so there is no need to warn about unimplemented instances.
|
@dcodeIO Should I remove it from the |
|
I thought we agreed to make it a pedantic message, i.e. move it to the pedantic range + pedantic check? |
|
Oh you're right! |
This reverts commit 41133e3.
|
Not sure what you mean |
|
It still emits the pedantic message, though. Needs |
|
@dcodeIO This should be good to go. |
|
Oh, wait, I think we also need to move the diagnostic to the pedantic range starting at 901 :) |
|
Thanks! |
|
I am not sure btw why you'd answer my request for this trivial change to keep numbering consistent with a confused emoji. But no problem, going to make the change myself :) |
|
It was because I was confused at the time. |
Because of tree shaking unused methods or class aren't compiled so there is no need to warn about unimplemented instances.