Implicitly inherit from Object - #2559
Merged
Merged
Conversation
CountBleck
added a commit
to CountBleck/assemblyscript-website
that referenced
this pull request
Nov 12, 2022
The class IDs for ArrayBuffer and String have now been incremented by 1.
dcodeIO
marked this pull request as ready for review
November 13, 2022 06:36
Contributor
|
Thank you for this! I was able to test the branch with as-pect and it works after I made some coding changes. I also needed to use the new loader because the runtime type ids changed. Other than that, everything looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classes that are not unmanaged and don't extend other classes now implicitly extend
Object. As a result, the typeObjectcan be used to reference and pass along any normal class instance.Note: Does not apply to basic value types like
i32, which are not objects.With
Objectbecoming the general base class, a breaking change to constant class ids was necessary, in that foundational classes move one up. Relevant for external integration with the runtime, where these ids may be hardcoded.