close
Skip to content

Account for non-lowercase VIDEO tag in render_block_core_video() - #80537

Merged
westonruter merged 1 commit into
trunkfrom
update/video-tag-gate
Jul 22, 2026
Merged

Account for non-lowercase VIDEO tag in render_block_core_video()#80537
westonruter merged 1 commit into
trunkfrom
update/video-tag-gate

Conversation

@westonruter

Copy link
Copy Markdown
Member

This is a follow-up to #70293.

I realized that the str_contains( '<video' ) check was incomplete, since HTML allows <VIDEO> as well as <video>. This covers all the bases. It also matches what is done in the Image block:

if ( false === stripos( $content, '<img' ) ) {

Use of AI Tools

Copilot brought this to my attention somewhere else: https://github.com/WordPress/wordpress-develop/pull/12503/changes#r3623776272

@westonruter
westonruter requested a review from ajitbohra as a code owner July 21, 2026 17:33
@westonruter westonruter added the [Type] Bug An existing feature does not function as intended label Jul 21, 2026
@westonruter
westonruter requested a review from fabiankaegy as a code owner July 21, 2026 17:33
@westonruter westonruter added the [Block] Video Affects the Video Block label Jul 21, 2026
@github-actions github-actions Bot added the [Package] Block library /packages/block-library label Jul 21, 2026
@westonruter westonruter added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Jul 21, 2026

@adamsilverstein adamsilverstein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter
westonruter merged commit c95188e into trunk Jul 22, 2026
57 of 58 checks passed
@westonruter
westonruter deleted the update/video-tag-gate branch July 22, 2026 03:29
@github-actions github-actions Bot added this to the Gutenberg 23.7 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Video Affects the Video Block No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants