close
Skip to content

add pr_info GitHub actions run - #2586

Merged
WebFreak001 merged 1 commit into
dlang:masterfrom
WebFreak001:pr_info
Mar 9, 2023
Merged

add pr_info GitHub actions run#2586
WebFreak001 merged 1 commit into
dlang:masterfrom
WebFreak001:pr_info

Conversation

@WebFreak001

@WebFreak001 WebFreak001 commented Feb 10, 2023

Copy link
Copy Markdown
Member

Gives summary about some basic statistics, deprecations and warnings.

The added action will fail here because it's a PR that's adding an action and the action needs access to the GITHUB_TOKEN to post comments on issues

Sample output: WebFreak001#1

Comment thread .github/workflows/pr_info.yml Outdated
runs-on: ubuntu-20.04
steps:
- name: 'Prepare sticky comment'
uses: marocchino/sticky-pull-request-comment@v2

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use an exact commit / version with this action or trust on them not introducing malicious content?

I think an exact commit would be more secure.

(2 occurrences of this)

@rikkimax

rikkimax commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

It looks like there is some sort of permission problem and hence isn't running right now, so not currently mergeable until someone with admin privileges fixes it (I think).

@WebFreak001

Copy link
Copy Markdown
Member Author

no, the problem is that I PRd from my repository, which has a different access token - so the comment action fails to run here because running modified CI scripts in the security context of the target repository would just be broken.

It will start working once merged, see the linked PR

@rikkimax

rikkimax commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

Okay looks good +1

Gives summary about some basic statistics, deprecations and warnings
@WebFreak001
WebFreak001 merged commit 3ea6bbe into dlang:master Mar 9, 2023
@WebFreak001
WebFreak001 deleted the pr_info branch March 9, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants