Fix flags Json serialization - #2643
Merged
Merged
Conversation
These flags always appear empty in `dub describe`
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 15 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5276640 bin/dub
+executable size=5280736 bin/dub
rough build time=76sFull build output |
WebFreak001
approved these changes
May 18, 2023
Member
|
CI failures unrelated / pre-existing |
WebFreak001
reviewed
May 18, 2023
WebFreak001
left a comment
Member
There was a problem hiding this comment.
first thought this may have been introduced with the yaml changes, but it looks like this issue was present before, so not a regression but a bug fix. Will merge now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags always appear empty in
dub describe