vcpkg add port: Handle feature core. - #1163
Conversation
ac43244 to
c9c8b1c
Compare
| "dependencies": [ | ||
| { | ||
| "name": "sqlite3", | ||
| "default-features": false, |
There was a problem hiding this comment.
I think this should be clarified that this is still here from the previous run, but it would also be better to have an independent test with [core,somethingelse].
There was a problem hiding this comment.
On second thought I think this should make default features be true because that's what sqlite3[zlib] requests.
Robert Schumacher (@ras0219-msft) also points out that we should have tests for multiple references to the same name
There was a problem hiding this comment.
I now have the test vcpkg add port "sqlite3" "sqlite3[core]"
|
Augustin Popa (@AugP) Victor Romero (@vicroms) dan-shaw Robert Schumacher (@ras0219-msft) Javier Matos Denizac (@JavierMatosD) and I discussed this today and it gets design approval modulo the nitpicks above |
Billy O'Neal (BillyONeal)
left a comment
There was a problem hiding this comment.
I pushed a merge with main for you; do you want me to fix the behavior bit I pointed out for you here and merge?
Sorry for the late answer. Yeah you could have done that 😅 I have not implemented this |
|
Thanks! |
Don't crash at
vcpkg add port sqlite3[core]Now sets
"default-featues": false