close
Skip to content

Remove //TODO placeholder#43267

Merged
Josh-Cena merged 3 commits intomdn:mainfrom
pranjal2004838:feature/clean-getelementattribute-fix
Apr 8, 2026
Merged

Remove //TODO placeholder#43267
Josh-Cena merged 3 commits intomdn:mainfrom
pranjal2004838:feature/clean-getelementattribute-fix

Conversation

@pranjal2004838
Copy link
Copy Markdown
Contributor

Replaces a leftover //TODO placeholder with a realistic "src" example in Get Element Attribute docs, and normalizes path separators in front-matter error messages on Windows. All tests pass locally.

@pranjal2004838 pranjal2004838 requested review from a team as code owners February 27, 2026 01:43
@pranjal2004838 pranjal2004838 requested review from LeoMcA and chrisdavidmills and removed request for a team February 27, 2026 01:43
@github-actions github-actions bot added Content:WebDriver WebDriver docs system [PR only] Infrastructure and configuration for the project labels Feb 27, 2026
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Feb 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 27, 2026

Preview URLs (1 page)

Flaws (7)

Found an unexpected or unresolvable flaw? Please report it here.

URL: /en-US/docs/Web/WebDriver/Reference/Classic/Commands/GetElementAttribute
Title: Get Element Attribute
Flaw count: 7

  • broken_links:
    • Link /en-US/docs/Web/WebDriver/Reference/Command doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/WebElement doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/WebElement doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/WebElement doesn't resolve
    • Link /en-US/docs/Web/WebDriver/Reference/Errors/SessionNotCreated doesn't resolve
    • and 2 more flaws omitted

(comment last updated: 2026-04-08 19:36:31)

LeoMcA
LeoMcA previously requested changes Feb 27, 2026
@pranjal2004838 pranjal2004838 force-pushed the feature/clean-getelementattribute-fix branch from 37103c9 to 2faeee7 Compare February 27, 2026 15:21
@github-actions github-actions bot removed the system [PR only] Infrastructure and configuration for the project label Feb 27, 2026
@LeoMcA LeoMcA changed the title fix(getelementattribute): replace //TODO placeholder with src; normalize path separators on Windows fix(getelementattribute): replace //TODO placeholder with src Mar 2, 2026
@LeoMcA LeoMcA removed their request for review March 2, 2026 10:26
@LeoMcA LeoMcA dismissed their stale review March 2, 2026 10:27

non-content change removed

Copilot AI review requested due to automatic review settings April 8, 2026 19:33
@Josh-Cena Josh-Cena changed the title fix(getelementattribute): replace //TODO placeholder with src Remove //TODO placeholder Apr 8, 2026
Copy link
Copy Markdown
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Josh-Cena Josh-Cena merged commit b666ae2 into mdn:main Apr 8, 2026
8 of 9 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MDN WebDriver “Get Element Attribute” command documentation to remove an unrealistic placeholder and replace it with a more accurate, spec-aligned description of return values.

Changes:

  • Rewrites the introductory description for “Get Element Attribute” to describe returned values (including boolean attributes and null for absent attributes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

---

The _Get Element Attribute_ [command](/en-US/docs/Web/WebDriver/Reference/Command) of the [WebDriver](/en-US/docs/Web/WebDriver) API returns the attribute of the referenced [web element](/en-US/docs/Web/WebDriver/Reference/WebElement). If for example the element is an {{HTMLElement("img")}}, the returned attribute is `"//TODO"`, which is equivalent to calling {{domxref("Element.getAttribute")}} on the element. For XML/XHTML documents it may be cased differently.
The _Get Element Attribute_ [command](/en-US/docs/Web/WebDriver/Reference/Command) of the [WebDriver](/en-US/docs/Web/WebDriver) API returns the value associated with the attribute of the given name of the referenced [web element](/en-US/docs/Web/WebDriver/Reference/WebElement). For boolean attributes, the associated value is `"true"` if present. Absent attributes return `null`. It is equivalent to calling {{domxref("Element.getAttribute()")}} on the element in JavaScript.
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description mention replacing a "//TODO" placeholder with a realistic "src" example and normalizing Windows path separators in front-matter error messages, but this change updates the intro text without adding a "src" example, and no front-matter error-path normalization is reflected here. Please either (a) update the PR title/description to match the actual scope, or (b) include the missing "src" example and the Windows path-separator normalization change in this PR.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebDriver WebDriver docs size/xs [PR only] 0-5 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants