close
Skip to content

Removing unnecessary lines in .travis.yml#46044

Merged
joaomoreno merged 1 commit into
microsoft:masterfrom
amtlib-dot-dll:patch-1
Mar 19, 2018
Merged

Removing unnecessary lines in .travis.yml#46044
joaomoreno merged 1 commit into
microsoft:masterfrom
amtlib-dot-dll:patch-1

Conversation

@amtlib-dot-dll

Copy link
Copy Markdown
Contributor

#46043

As Travis CI have nvm shipped in their images, there is no need to install nvm again

@amtlib-dot-dll

Copy link
Copy Markdown
Contributor Author

The removed lines does not affect the test result as is shown in the Travis log 🤔 The master branch won't pass the test at all

@joaomoreno

Copy link
Copy Markdown
Member

Looks good! Thanks! 🍻

@joaomoreno joaomoreno added this to the March 2018 milestone Mar 19, 2018
@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Mar 19, 2018
@joaomoreno joaomoreno merged commit 8d5d595 into microsoft:master Mar 19, 2018
@amtlib-dot-dll amtlib-dot-dll deleted the patch-1 branch March 19, 2018 11:52
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engineering VS Code - Build / issue tracking / etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants