close
Skip to content

Split Terminal Command based on Workspace Path #45694#46461

Merged
Tyriar merged 2 commits into
microsoft:masterfrom
knyhle:master
Apr 2, 2018
Merged

Split Terminal Command based on Workspace Path #45694#46461
Tyriar merged 2 commits into
microsoft:masterfrom
knyhle:master

Conversation

@knyhle

@knyhle knyhle commented Mar 24, 2018

Copy link
Copy Markdown
Contributor

Add feature requested: #45694

Made Split Terminal work like the Create Terminal command including (In Active Workspace) option.

out

@msftclas

msftclas commented Mar 24, 2018

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@Tyriar

Tyriar commented Mar 27, 2018

Copy link
Copy Markdown
Contributor

Thanks @kennyle1412! I'll check this out soon for the April release as we're currently in endgame/testing for the March release. Could you fix the conflicts in the meantime?

@Tyriar Tyriar added this to the April 2018 milestone Mar 27, 2018
@knyhle

knyhle commented Mar 27, 2018

Copy link
Copy Markdown
Contributor Author

@Tyriar yeah, no problem! Take as long as you need.

@nzec nzec left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

knyhle added 2 commits April 2, 2018 13:39
Similar functionality to CreateTerminalInActiveWorkspace for
CreateTerminal for no prompt creation.

@Tyriar Tyriar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyle1412 really nice PR! 👍

@Tyriar Tyriar merged commit 97dcb55 into microsoft:master Apr 2, 2018
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants