enforce authentication in API tests and improve error handling for unauthenticated requests#21558
Merged
Merged
Conversation
adfoster-r7
approved these changes
Jun 10, 2026
dwelch-r7
force-pushed
the
fix-api-app-test-stacktrace
branch
from
June 10, 2026 16:23
7d06bf4 to
e799f13
Compare
…authenticated requests
dwelch-r7
force-pushed
the
fix-api-app-test-stacktrace
branch
from
June 10, 2026 16:28
e799f13 to
dd2475b
Compare
adfoster-r7
approved these changes
Jun 10, 2026
Contributor
|
FWIW, I've also been getting this stack trace a lot lately. Thanks for taking a look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting this stacktrace
dug into it and it seems like a brittle test that was logging out the error but not causing the test itself to fail, this PR addresses that
Verification steps
bundle exec rspec spec/api/metasploit_api_app_spec.rb