close
Skip to content

[Feat][Connector-v2][Kafka] Add support for Schema Registry wire format in Protobuf deserialization#10183

Merged
corgy-w merged 7 commits into
apache:devfrom
zhangshenghang:feat-kafka-protobuf-schema
Jan 29, 2026
Merged

[Feat][Connector-v2][Kafka] Add support for Schema Registry wire format in Protobuf deserialization#10183
corgy-w merged 7 commits into
apache:devfrom
zhangshenghang:feat-kafka-protobuf-schema

Conversation

@zhangshenghang

Copy link
Copy Markdown
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@zhangshenghang zhangshenghang changed the title [Feat][Kafka] Add support for Schema Registry wire format in Protobuf deserialization [Feat][Connector-v2][Kafka] Add support for Schema Registry wire format in Protobuf deserialization Dec 11, 2025
@zhangshenghang zhangshenghang marked this pull request as ready for review December 12, 2025 14:42

@chl-wxp chl-wxp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AutoService(Factory.class)
public class KafkaSourceFactory implements TableSourceFactory {

    @Override
    public String factoryIdentifier() {
        return "Kafka";
    }

    @Override
    public OptionRule optionRule() {
        return OptionRule.builder()
                .required(KafkaSourceOptions.BOOTSTRAP_SERVERS)
                .exclusive(
                        KafkaSourceOptions.TOPIC,
                        KafkaSourceOptions.TABLE_CONFIGS,
                        KafkaSourceOptions.TABLE_LIST)
                .optional(
                        KafkaSourceOptions.START_MODE,
+             .optional(KafkaSourceOptions.STRIP_SCHEMA_REGISTRY_HEADER)

@chl-wxp

chl-wxp commented Dec 15, 2025

Copy link
Copy Markdown
Member

please add doc

@zhangshenghang

Copy link
Copy Markdown
Member Author

@chl-wxp @davidzollo @corgy-w ptal

davidzollo
davidzollo previously approved these changes Dec 30, 2025

@davidzollo davidzollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

davidzollo
davidzollo previously approved these changes Jan 12, 2026

@davidzollo davidzollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if CI passed

@chl-wxp chl-wxp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidzollo davidzollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

@corgy-w corgy-w merged commit 6948d34 into apache:dev Jan 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants