close
Skip to content

[BugFix] [InfluxDBSource] Resolve invalid SQL in initColumnsIndex method caused by direct QUERY_LIMIT appendage with 'tz' function.#4829

Merged
EricJoy2048 merged 10 commits into
apache:devfrom
zhengyuan-cn:dev
Nov 27, 2023
Merged

[BugFix] [InfluxDBSource] Resolve invalid SQL in initColumnsIndex method caused by direct QUERY_LIMIT appendage with 'tz' function.#4829
EricJoy2048 merged 10 commits into
apache:devfrom
zhengyuan-cn:dev

Conversation

@zhengyuan-cn

@zhengyuan-cn zhengyuan-cn commented May 25, 2023

Copy link
Copy Markdown
Contributor

recommit RP for [Bug] connector-influxdb module InfluxDBSource class's initColumnsIndex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT #4231

Purpose of this pull request

Check list

…ex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT apache#4231
@ic4y ic4y changed the title [Bug] connector-influxdb module InfluxDBSource class's initColumnsIndex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT #4231 [BugFix] [InfluxDBSource] Resolve invalid SQL in initColumnsIndex method caused by direct QUERY_LIMIT appendage with 'tz' function. Aug 5, 2023
@ic4y

ic4y commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

@Hisoka-X Can you help figure out why there's no CI/CD?
image

@ic4y ic4y closed this Aug 5, 2023
@ic4y ic4y reopened this Aug 5, 2023
@ic4y

ic4y commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

@Hisoka-X Can you help figure out why there's no CI/CD? image

It's alright now, just close and reopen the PR.

@ic4y

ic4y commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

@zhengyuan-cn Please use mvn spotless:apply to format the code.

@zhengyuan-cn

Copy link
Copy Markdown
Contributor Author

@zhengyuan-cn Please use mvn spotless:apply to format the code.

OK, formated

@hailin0 hailin0 closed this Oct 25, 2023
@hailin0 hailin0 reopened this Oct 25, 2023
@hailin0

hailin0 commented Oct 25, 2023

Copy link
Copy Markdown
Member

@zhengyuan-cn

image

@Hisoka-X Hisoka-X added bug First-time contributor First-time contributor labels Oct 27, 2023
@zhengyuan-cn

Copy link
Copy Markdown
Contributor Author

@Hisoka-X @ic4y @hailin0 all checks have passed, please review code.

@zhengyuan-cn

Copy link
Copy Markdown
Contributor Author

@Hisoka-X I accidentally clicked on the review request

@Hisoka-X

Copy link
Copy Markdown
Member

cc @hailin0

@EricJoy2048 EricJoy2048 merged commit deed9c6 into apache:dev Nov 27, 2023
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
…hod caused by direct QUERY_LIMIT appendage with 'tz' function. (apache#4829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants