close
Skip to content

[Improve][CheckStyle] Remove useless 'SuppressWarnings' annotation of checkstyle.#5260

Merged
Hisoka-X merged 1 commit into
apache:devfrom
FlechazoW:dev
Aug 18, 2023
Merged

[Improve][CheckStyle] Remove useless 'SuppressWarnings' annotation of checkstyle.#5260
Hisoka-X merged 1 commit into
apache:devfrom
FlechazoW:dev

Conversation

@FlechazoW

Copy link
Copy Markdown
Contributor

Remove useless 'SuppressWarnings' annotation of checkstyle.

Purpose of this pull request

Check list

@EricJoy2048

Copy link
Copy Markdown
Member

LGTM, Please wait CI.

@Hisoka-X

Copy link
Copy Markdown
Member

After we clean up these annotations, is there any benefit, what if someone adds corresponding annotations in the future?

@liugddx

liugddx commented Aug 18, 2023

Copy link
Copy Markdown
Member

After we clean up these annotations, is there any benefit, what if someone adds corresponding annotations in the future?

This annotation is provided by checkstyle, we are not using it now and checkstyle should not be added automatically.

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, merging.

@Hisoka-X Hisoka-X merged commit 51c0d70 into apache:dev Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants