[Improve] Mark SeaTunnelPluginLifeCycle as deprecated#5625
Conversation
|
We should remove it in 2.3.6, should not earlier than 2.3.6. We should leave time to developer which had customed their own plugin. But it depends on our progress on implement Factory SPI. |
| * @deprecated SeaTunnel will not invoke prepare when init plugin, instead by {@link | ||
| * org.apache.seatunnel.api.table.factory.Factory} | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Will these APIs be marked @deprecated?
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SeaTunnelSink.java#L58
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SeaTunnelSink.java#L65
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/transform/SeaTunnelTransform.java#L42
https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/transform/SeaTunnelTransform.java#L49
There was a problem hiding this comment.
Done. But https://github.com/apache/seatunnel/blob/dev/seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SeaTunnelSink.java#L65 doesn't deprecated. Because we don't have a replacement yet
There was a problem hiding this comment.
But it will be deprecated in the future
Purpose of this pull request
This PR mark
SeaTunnelPluginLifeCycleas deprecated. Prepare to remove it.Does this PR introduce any user-facing change?
No
How was this patch tested?
unnecessary
Check list
New License Guide
release-note.