close
Skip to content

[Improve] Mark SeaTunnelPluginLifeCycle as deprecated#5625

Merged
hailin0 merged 2 commits into
apache:devfrom
Hisoka-X:prepare-mark-deprecated
Oct 16, 2023
Merged

[Improve] Mark SeaTunnelPluginLifeCycle as deprecated#5625
hailin0 merged 2 commits into
apache:devfrom
Hisoka-X:prepare-mark-deprecated

Conversation

@Hisoka-X

Copy link
Copy Markdown
Member

Purpose of this pull request

This PR mark SeaTunnelPluginLifeCycle as deprecated. Prepare to remove it.

Does this PR introduce any user-facing change?

No

How was this patch tested?

unnecessary

Check list

@Hisoka-X Hisoka-X added the api label Oct 13, 2023
@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Oct 13, 2023
@Hisoka-X

Hisoka-X commented Oct 13, 2023

Copy link
Copy Markdown
Member Author

We should remove it in 2.3.6, should not earlier than 2.3.6. We should leave time to developer which had customed their own plugin. But it depends on our progress on implement Factory SPI.

* @deprecated SeaTunnel will not invoke prepare when init plugin, instead by {@link
* org.apache.seatunnel.api.table.factory.Factory}
*/
@Deprecated

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it will be deprecated in the future

@ruanwenjun ruanwenjun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit eb6d4cf into apache:dev Oct 16, 2023
@Hisoka-X Hisoka-X deleted the prepare-mark-deprecated branch October 17, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants