[Improve][Connector-V2]Support multi-table sink feature for httpsink#6316
Merged
Conversation
Hisoka-X
reviewed
Feb 2, 2024
Hisoka-X
left a comment
Member
There was a problem hiding this comment.
LGTM. Only one minor comment
| throws IOException, InterruptedException { | ||
| Container.ExecResult execResult = container.executeJob("/fake_to_multitable.conf"); | ||
| Assertions.assertEquals(0, execResult.getExitCode()); | ||
| Assertions.assertTrue(getContentCounts(execResult.getStdout())); |
Member
There was a problem hiding this comment.
Suggested change
| Assertions.assertTrue(getContentCounts(execResult.getStdout())); | |
| Assertions.assertTrue(execResult.getStdout().contains(successCount)); |
Hisoka-X
approved these changes
Feb 5, 2024
Hisoka-X
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks @jackyyyyyssss !
hailin0
approved these changes
Feb 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support multi-table sink feature for http add e2e case #5652
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.