close
Skip to content

[bugFix][Connector-V2][Doris] The multi-FE configuration is supported#6341

Merged
hailin0 merged 6 commits into
apache:devfrom
Carl-Zhou-CN:doris-fe
May 13, 2024
Merged

[bugFix][Connector-V2][Doris] The multi-FE configuration is supported#6341
hailin0 merged 6 commits into
apache:devfrom
Carl-Zhou-CN:doris-fe

Conversation

@Carl-Zhou-CN

@Carl-Zhou-CN Carl-Zhou-CN commented Feb 6, 2024

Copy link
Copy Markdown
Member

Purpose of this pull request

close #6337

Does this PR introduce any user-facing change?

How was this patch tested?

Current test

Check list

@Hisoka-X

Hisoka-X commented Feb 6, 2024

Copy link
Copy Markdown
Member

Could you add a test case for this?

@Carl-Zhou-CN

Copy link
Copy Markdown
Member Author

Could you add a test case for this?

Ok, I'll add it, but right now I can't find a multi-Fe docker image


@VisibleForTesting
static String randomEndpoint(String feNodes, Logger logger) throws DorisConnectorException {
public static String randomEndpoint(String feNodes, Logger logger)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use UT to test this method is enough.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @Hisoka-X

@Carl-Zhou-CN

Copy link
Copy Markdown
Member Author

@Hisoka-X cc

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passed.

@hailin0 hailin0 merged commit b6d0751 into apache:dev May 13, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.3.4同步数据到doris异常

4 participants