close
Skip to content

[Improve] Add deprecated annotation for ReadonlyConfig::toConfig#6353

Merged
hailin0 merged 6 commits into
apache:devfrom
Hisoka-X:toconfig-deprecated
Mar 6, 2024
Merged

[Improve] Add deprecated annotation for ReadonlyConfig::toConfig#6353
hailin0 merged 6 commits into
apache:devfrom
Hisoka-X:toconfig-deprecated

Conversation

@Hisoka-X

Copy link
Copy Markdown
Member

Purpose of this pull request

This PR add deprecated annotation for ReadonlyConfig::toConfig. We should make sure it not be used with new code. Because we will delete it in the future.

Does this PR introduce any user-facing change?

no

How was this patch tested?

unnecessary.

Check list

@Hisoka-X Hisoka-X force-pushed the toconfig-deprecated branch from f89d2a9 to 6bd8ff0 Compare February 21, 2024 01:59
@Hisoka-X

Copy link
Copy Markdown
Member Author

cc @hailin0 @EricJoy2048 @ruanwenjun

@hailin0 hailin0 merged commit f477634 into apache:dev Mar 6, 2024
@Hisoka-X Hisoka-X deleted the toconfig-deprecated branch March 11, 2024 07:35
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants