close
Skip to content

[Hotfix][Zeta] Fix job deadlock when schema change#6389

Merged
Hisoka-X merged 1 commit into
apache:devfrom
hailin0:dev-fix-job-deadlock
Mar 6, 2024
Merged

[Hotfix][Zeta] Fix job deadlock when schema change#6389
Hisoka-X merged 1 commit into
apache:devfrom
hailin0:dev-fix-job-deadlock

Conversation

@hailin0

@hailin0 hailin0 commented Feb 26, 2024

Copy link
Copy Markdown
Member

Purpose of this pull request

[Zeta] Fix job deadlock when schema change

Execute timeline:

  1. runningTask.triggerSchemaChangeBeforeCheckpoint().get() starting
  2. SourceFlowLifeCycle#triggerBarrier(Barrier barrier) executed, schemaChangePhase is null at this time
  3. runningTask.triggerSchemaChangeBeforeCheckpoint().get() end
  4. SourceFlowLifeCycle#notifyCheckpointEnd(long checkpointId) executed, , schemaChangePhase is null at this time
  5. schemaChangePhase.set(SchemaChangePhase.createBeforePhase()) executed
  6. SourceFlowLifeCycle#collect() execute, check schemaChanging() is true, job enter an endless loop

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

@Hisoka-X

Copy link
Copy Markdown
Member

Please add test case.

@hailin0

hailin0 commented Mar 6, 2024

Copy link
Copy Markdown
Member Author

Please add test case.

@Hisoka-X
Currently not possible to add testcase because the ddl event capture has not been developed yet.

@Hisoka-X Hisoka-X merged commit e1a81ac into apache:dev Mar 6, 2024
@hailin0

hailin0 commented May 31, 2024

Copy link
Copy Markdown
Member Author

fix #5125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants