close
Skip to content

[Improve][Transform] Remove can't find field exception #6691

Merged
hailin0 merged 2 commits into
apache:devfrom
TongchengOpenSource:filter_transform_2
Apr 12, 2024
Merged

[Improve][Transform] Remove can't find field exception #6691
hailin0 merged 2 commits into
apache:devfrom
TongchengOpenSource:filter_transform_2

Conversation

@xiaochen-zhou

Copy link
Copy Markdown
Contributor

Purpose of this pull request

In the FilterFieldTransform, we don't need to use try{} catch to obtain the canNotFoundFields collection, and we can remove the redundant cannotFindInputFieldError logic in the FilterFieldTransform#transformTableSchema().

Does this PR introduce any user-facing change?
no

How was this patch tested?
exist tests.

How was this patch tested?

Check list

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @xiaochen-zhou

@hailin0 hailin0 merged commit ffae2f7 into apache:dev Apr 12, 2024
lostinwind added a commit to lostinwind/dataGovernance that referenced this pull request Apr 15, 2024
@xiaochen-zhou xiaochen-zhou deleted the filter_transform_2 branch May 3, 2024 09:56
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants