close
Skip to content

[Feature][Connector-V2] Suport choose the start page in http paging#7180

Merged
wuchunfu merged 8 commits into
apache:devfrom
Gxinge:http_start_page
Aug 22, 2024
Merged

[Feature][Connector-V2] Suport choose the start page in http paging#7180
wuchunfu merged 8 commits into
apache:devfrom
Gxinge:http_start_page

Conversation

@Gxinge

@Gxinge Gxinge commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

In this branch I added a parameter for http paging: start_page. This parameter helps us specify the start page of the page, for example I can start reading data from page 30

@Hisoka-X

Copy link
Copy Markdown
Member

Thanks @Gxinge created this PR! Seem like the github action not started right.. Could you open github action on your fork repository first?
image

@Hisoka-X Hisoka-X added First-time contributor First-time contributor feature New feature connectors-v2 labels Jul 12, 2024
@Gxinge

Gxinge commented Jul 12, 2024

Copy link
Copy Markdown
Contributor Author

yes,when you use start page, you can choose to start reading from any page.and if this parameter is not selected, the reading starts from the page one by default

@Hisoka-X

Copy link
Copy Markdown
Member

Hi @Gxinge , any update for this comment? #7180 (comment) . Feel free to ask if you encountered problem.

@Hisoka-X

Hisoka-X commented Aug 9, 2024

Copy link
Copy Markdown
Member

Please run 'mvn spotless:apply' to fix code style before commit.

@Hisoka-X Hisoka-X added this to the 2.3.8 milestone Aug 21, 2024

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Gxinge

@Hisoka-X Hisoka-X changed the title [Feature][Connector-V2] Suport choose the home page in http paging [Feature][Connector-V2] Suport choose the start page in http paging Aug 22, 2024
@wuchunfu wuchunfu merged commit ed15f0d into apache:dev Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whether the paging function of the http connector can specify the page from which to read

3 participants