[Feature][Connector-V2] Fake Source support produce vector data#7401
Merged
Conversation
4 tasks
Hisoka-X
reviewed
Aug 19, 2024
Comment on lines
+328
to
+330
| case BINARY_VECTOR: | ||
| case BFLOAT16_VECTOR: | ||
| case FLOAT16_VECTOR: |
Hisoka-X
approved these changes
Aug 19, 2024
hailin0
reviewed
Aug 20, 2024
|
|
||
| public static final VectorType<Byte> VECTOR_BINARY_TYPE = | ||
| new VectorType<>(Byte.class, SqlType.BINARY_VECTOR); | ||
| public static final VectorType<ByteBuffer> VECTOR_BINARY_TYPE = |
Member
There was a problem hiding this comment.
Is this change compatible with older versions?
Contributor
Author
There was a problem hiding this comment.
Currently first connector of binary vectors is implemented in this pr with no historical version problem
hailin0
approved these changes
Aug 20, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
issue : #7390
eg:
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.