close
Skip to content

[Improve][API] Add IGNORE savemode type#7443

Merged
hailin0 merged 6 commits into
apache:devfrom
jw-itq:dev
Aug 22, 2024
Merged

[Improve][API] Add IGNORE savemode type#7443
hailin0 merged 6 commits into
apache:devfrom
jw-itq:dev

Conversation

@jw-itq

@jw-itq jw-itq commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

Fix #7430

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@jw-itq jw-itq closed this Aug 21, 2024
@jw-itq jw-itq reopened this Aug 21, 2024
@Hisoka-X Hisoka-X changed the title [Fix] [sink elasticsearch] Fix the issue of sink-es saveMode and es automatic index creation conflict #7430 [Improve][API] Add IGNORE savemode type Aug 21, 2024
Comment on lines +37 to +38
// Ignore
IGNORE

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataSaveMode doesn't need IGNORE. The behavior of IGNORE same as APPEND_DATA.

@jw-itq jw-itq Aug 21, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataSaveMode doesn't need IGNORE. The behavior of IGNORE same as APPEND_DATA.

ok, thanks. I want to try again

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update doc.
image

@jw-itq

jw-itq commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

Please update doc. image

ok, thanks.

jw-itq added a commit to jw-itq/seatunnel that referenced this pull request Aug 22, 2024

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @jw-itq

@hailin0 hailin0 merged commit 825caa8 into apache:dev Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [sink elasticsearch] the savemode of sink-es conficts with es automatically creating indexes based on templates

3 participants