close
Skip to content

[Feature][Connector-V2]Support tidb cdc connector source#7477

Merged
Hisoka-X merged 1 commit into
apache:devfrom
sunxiaojian:support-tidb-cdc
Sep 11, 2024
Merged

[Feature][Connector-V2]Support tidb cdc connector source#7477
Hisoka-X merged 1 commit into
apache:devfrom
sunxiaojian:support-tidb-cdc

Conversation

@sunxiaojian

@sunxiaojian sunxiaojian commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Purpose of this pull request

closed #7199

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Comment thread .idea/vcs.xml
@@ -1,24 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why update this file

Comment thread docs/en/connector-v2/source/TiDB-CDC.md Outdated
@@ -0,0 +1,129 @@
# PostgreSQL CDC

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add zh docs

case MYSQL_NULL:
builder.dataType(BasicType.VOID_TYPE);
break;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

value = {},
type = {EngineType.SPARK},
disabledReason = "Currently SPARK do not support cdc")
public class TiDBCDCIT extends TiDBTestBase implements TestResource {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 4 times, most recently from 8267c66 to 4bc7d20 Compare August 24, 2024 13:11
Comment thread docs/zh/connector-v2/source/TiDB-CDC.md Outdated

## 主要功能

- [x] [批处理](../../concept/connector-v2-features.md)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support batch mode?

@hailin0

hailin0 commented Aug 24, 2024

Copy link
Copy Markdown
Member

cc @dailai

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 4 times, most recently from 90ba526 to bbae550 Compare August 26, 2024 07:57
@dailai

dailai commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

Please resolve the confilict and retrigger the ci.

@dailai

dailai commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

Please fix the ci.

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 2 times, most recently from 3e63cac to 090fcdf Compare September 2, 2024 06:07
value = {},
type = {EngineType.SPARK},
disabledReason = "Currently SPARK do not support cdc")
public class TiDBCDCIT extends TiDBTestBase implements TestResource {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunxiaojian. Please add the e2e case that restore from savepoint.

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 3 times, most recently from b562f81 to c4d1fde Compare September 5, 2024 03:53

@dailai dailai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/en/connector-v2/source/TiDB-CDC.md Outdated

@hailin0 hailin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit 87ec786 into apache:dev Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][CDC] Support tidb cdc connector source

4 participants