[Feature][Zeta] Support slf4j mdc tracing job id output into logs#7491
Merged
Conversation
Member
Author
3 tasks
b2e749e to
b8fcb17
Compare
c9c175d to
9c546ec
Compare
0c06e63 to
a2860eb
Compare
a2860eb to
188047b
Compare
5c93167 to
ed5e863
Compare
ed5e863 to
33490a6
Compare
hailin0
commented
Sep 1, 2024
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-log4j12</artifactId> |
hailin0
commented
Sep 1, 2024
|
|
||
| # Log4j2 Config | ||
| JAVA_OPTS="${JAVA_OPTS} -Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector" | ||
| JAVA_OPTS="${JAVA_OPTS} -Dlog4j2.isThreadContextMapInheritable=true" |
Member
Author
There was a problem hiding this comment.
Hisoka-X
approved these changes
Sep 2, 2024
Contributor
|
Good feature, Thanks @hailin0 for working on this. |
Member
Author
@arshadmohammad |
Contributor
|
I was looking for functionality similar to mapreduce and yarn, all mapreduce jobs have separate logs. |
Member
Author
|
I will do some verification later |
This was referenced Sep 3, 2024
4 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Purpose of this pull request
[Feature][Zeta] Support slf4j mdc tracing job id output into logs
reference
https://www.slf4j.org/manual.html#mdc
https://logging.apache.org/log4j/2.x/manual/thread-context.html#configuration
https://logging.apache.org/log4j/2.x/manual/layouts.html#PatternLayout
subtask of #2725
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added
Check list
New License Guide
release-note.