close
Skip to content

[Feature][Connector-V2] sftp file sink suport multiple table and save mode#7668

Merged
hailin0 merged 6 commits into
apache:devfrom
chl-wxp:sftp_support_multiple_and_save_mode
Sep 29, 2024
Merged

[Feature][Connector-V2] sftp file sink suport multiple table and save mode#7668
hailin0 merged 6 commits into
apache:devfrom
chl-wxp:sftp_support_multiple_and_save_mode

Conversation

@chl-wxp

@chl-wxp chl-wxp commented Sep 15, 2024

Copy link
Copy Markdown
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@TestTemplate
@DisabledOnContainer(
value = {},
type = {EngineType.FLINK, EngineType.SPARK},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type = {EngineType.FLINK, EngineType.SPARK},
type = {EngineType.FLINK},

@@ -0,0 +1,103 @@
#

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the test case file name. I can not get the difference of two config from config name.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment on lines +153 to +156
@DisabledOnContainer(
value = {},
type = {EngineType.FLINK},
disabledReason = "Flink dosen't support multi-table at now")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flink supported now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@hailin0 hailin0 merged commit dc4b989 into apache:dev Sep 29, 2024
dailai pushed a commit to dailai/seatunnel that referenced this pull request Oct 11, 2024
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
CosmosNi pushed a commit to CosmosNi/seatunnel that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants