close
Skip to content

[Fix][Connecotr-V2] Fix paimon dynamic bucket tale in primary key is not first#7728

Merged
hailin0 merged 1 commit into
apache:devfrom
hawk9821:paimon_bucket
Sep 27, 2024
Merged

[Fix][Connecotr-V2] Fix paimon dynamic bucket tale in primary key is not first#7728
hailin0 merged 1 commit into
apache:devfrom
hawk9821:paimon_bucket

Conversation

@hawk9821

Copy link
Copy Markdown
Contributor

Purpose of this pull request

Dynamic bucket allocation did not take into account that the primary key was not in the first place, resulting in an error when executing the loadBucketIndex method in the initialization of the PaimonBucketAssigner class . This pr fixed the problem

Does this PR introduce any user-facing change?

How was this patch tested?

PaimonSinkDynamicBucketIT#primaryFullTypeAndLoadData

Check list

@Hisoka-X

Copy link
Copy Markdown
Member

cc @dailai

@hawk9821 hawk9821 force-pushed the paimon_bucket branch 3 times, most recently from c74d040 to bcca704 Compare September 24, 2024 12:20
@Hisoka-X Hisoka-X changed the title [Fix][CONNECTORS-V2] fix dynamic bucket tale in primary key is not first [Fix][Connecotr-V2] Fix dynamic bucket tale in primary key is not first Sep 24, 2024
@Hisoka-X Hisoka-X changed the title [Fix][Connecotr-V2] Fix dynamic bucket tale in primary key is not first [Fix][Connecotr-V2] Fix paimon dynamic bucket tale in primary key is not first Sep 24, 2024
@hawk9821 hawk9821 force-pushed the paimon_bucket branch 2 times, most recently from 463ea30 to 73addf6 Compare September 25, 2024 04:52

@dailai dailai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Hisoka-X PTAL

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hawk9821 !

@hailin0 hailin0 merged commit dc7f695 into apache:dev Sep 27, 2024
@hawk9821 hawk9821 deleted the paimon_bucket branch September 27, 2024 06:30
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants