close
Skip to content

[Improve][Doc] Add some connector icons#7944

Merged
liugddx merged 4 commits into
apache:devfrom
zhangshenghang:doc-add-icon
Oct 31, 2024
Merged

[Improve][Doc] Add some connector icons#7944
liugddx merged 4 commits into
apache:devfrom
zhangshenghang:doc-add-icon

Conversation

@zhangshenghang

Copy link
Copy Markdown
Member

Purpose of this pull request

Add some connector icons

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@zhangshenghang zhangshenghang marked this pull request as ready for review October 31, 2024 02:24

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangshenghang

@hailin0 hailin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.
Hdfs文件.svg
Apache Iceberg.svg

Should it contain spaces and Chinese characters?

cc @Hisoka-X

@Hisoka-X

Copy link
Copy Markdown
Member

e.g. Hdfs文件.svg Apache Iceberg.svg

Should it contain spaces and Chinese characters?

cc @Hisoka-X

Yep, the current logic is use markdown header name to mapping icon file. So the header name is contains chinese, the icon file should contains it too.
image

@hailin0

hailin0 commented Oct 31, 2024

Copy link
Copy Markdown
Member

e.g. Hdfs文件.svg Apache Iceberg.svg

Should it contain spaces and Chinese characters?

cc @Hisoka-X

#7954

@zhangshenghang zhangshenghang deleted the doc-add-icon branch November 13, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants