close
Skip to content

[Feature][Clickhouse] Support sink savemode #8086

Merged
hailin0 merged 20 commits into
apache:devfrom
zhangshenghang:feature-add-ck-savemode
Dec 4, 2024
Merged

[Feature][Clickhouse] Support sink savemode #8086
hailin0 merged 20 commits into
apache:devfrom
zhangshenghang:feature-add-ck-savemode

Conversation

@zhangshenghang

@zhangshenghang zhangshenghang commented Nov 19, 2024

Copy link
Copy Markdown
Member

Purpose of this pull request

close #8060

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangshenghang ! Looks great!

Comment thread seatunnel-connectors-v2/connector-clickhouse/pom.xml
Comment thread docs/en/connector-v2/sink/Clickhouse.md Outdated
Hisoka-X
Hisoka-X previously approved these changes Dec 3, 2024

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zhangshenghang !

@Hisoka-X

Hisoka-X commented Dec 3, 2024

Copy link
Copy Markdown
Member

Please resolve conflicts.

Hisoka-X
Hisoka-X previously approved these changes Dec 4, 2024
@hailin0 hailin0 merged commit e6f92fd into apache:dev Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Clickhouse] Support sink savemode

3 participants