close
Skip to content

[Fix][Connector-V2] Fix jdbc sink statement buffer wrong time to clear#8653

Merged
davidzollo merged 2 commits into
apache:devfrom
Hisoka-X:fix-buffer-clear
Feb 13, 2025
Merged

[Fix][Connector-V2] Fix jdbc sink statement buffer wrong time to clear#8653
davidzollo merged 2 commits into
apache:devfrom
Hisoka-X:fix-buffer-clear

Conversation

@Hisoka-X

@Hisoka-X Hisoka-X commented Feb 12, 2025

Copy link
Copy Markdown
Member

Purpose of this pull request

The statement buffer should not be clear in finally block. It will loss data when retry in jdbc sink.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X marked this pull request as ready for review February 12, 2025 12:19
@hailin0

hailin0 commented Feb 12, 2025

Copy link
Copy Markdown
Member

link issue pr
#7533

@hailin0

hailin0 commented Feb 13, 2025

Copy link
Copy Markdown
Member

Add a UT?

@Hisoka-X

Copy link
Copy Markdown
Member Author

Add a UT?

done

@davidzollo davidzollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit cf35eec into apache:dev Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants