close
Skip to content

[improve] rabbit mq options#8740

Merged
hailin0 merged 1 commit into
apache:devfrom
liunaijie:improve/rabbitmq
Feb 19, 2025
Merged

[improve] rabbit mq options#8740
hailin0 merged 1 commit into
apache:devfrom
liunaijie:improve/rabbitmq

Conversation

@liunaijie

Copy link
Copy Markdown
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@liunaijie liunaijie marked this pull request as ready for review February 16, 2025 12:40
@akulabs8

Copy link
Copy Markdown
Contributor

one small doubt,
can you please explain the changes made to rabbitmqSource and rabbitmqSink classes?


@Setter
@Getter
@NoArgsConstructor

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add a no args constructor?

@liunaijie liunaijie Feb 16, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liunaijie

Copy link
Copy Markdown
Member Author

one small doubt, can you please explain the changes made to rabbitmqSource and rabbitmqSink classes?

image

This issue need to do 2 things:

  1. Organize the connector relevant parameters into XXXOptions class.
  2. implement createSource/createSink method in Factory class.

@hailin0 hailin0 merged commit 4eec9be into apache:dev Feb 19, 2025
@liunaijie liunaijie deleted the improve/rabbitmq branch February 22, 2025 05:24
zax1314157 pushed a commit to zax1314157/seatunnel that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants