close
Skip to content

[improve] update clickhouse connector config option#8755

Merged
Hisoka-X merged 14 commits into
apache:devfrom
lyne7-sc:dev
Feb 20, 2025
Merged

[improve] update clickhouse connector config option#8755
Hisoka-X merged 14 commits into
apache:devfrom
lyne7-sc:dev

Conversation

@lyne7-sc

Copy link
Copy Markdown
Contributor

Purpose of this pull request

subtask of #8576

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

liunaijie
liunaijie previously approved these changes Feb 18, 2025

@liunaijie liunaijie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wait CI pass

@lyne7-sc

Copy link
Copy Markdown
Contributor Author

Hi , @liunaijie
I noticed that the CI license header check failed in the previous PR. To address this, I've added a new commit to include the missing license headers for the following files:

  • ClickhouseFileSinkOptions.java
  • ClickhouseSinkOptions.java
  • ClickhouseSourceOptions.java

Please review this update at your convenience. Thanks!

@liunaijie

Copy link
Copy Markdown
Member

LGTM, Thanks! @lyne7-sc

@Hisoka-X Hisoka-X merged commit b964189 into apache:dev Feb 20, 2025
zax1314157 pushed a commit to zax1314157/seatunnel that referenced this pull request Feb 24, 2025
Co-authored-by: Lyne <lilinfeng0310@163.com>
Co-authored-by: Jia Fan <fanjiaeminem@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants