[Fix][MongoDB] The Long type cannot handle string values in scientific notation#8783
Merged
Conversation
Hisoka-X
reviewed
Feb 24, 2025
qifanlili
added a commit
to qifanlili/seatunnel
that referenced
this pull request
Mar 4, 2025
author lee <liqifan@cvte.com> 1740121208 +0800 committer lee <liqifan@cvte.com> 1741076125 +0800 parent a3a7b49 author lee <liqifan@cvte.com> 1740121208 +0800 committer lee <liqifan@cvte.com> 1741076105 +0800 [Fix][MongoDB] The Long type cannot handle string values in scientific notation. (apache#8783)
Contributor
Author
Okay, I've submitted it. |
Contributor
Author
|
@Hisoka-X Any other questions here? |
Hisoka-X
reviewed
Mar 25, 2025
Comment on lines
+76
to
+78
| Method method = SamplingSplitStrategy.class.getDeclaredMethod("getDocumentNumAndAvgSize"); | ||
| method.setAccessible(true); | ||
| ImmutablePair<Long, Long> result = (ImmutablePair<Long, Long>) method.invoke(strategy); |
Member
There was a problem hiding this comment.
Try not to use reflection to test your code. Let's set getDocumentNumAndAvgSize scope to default and add @VisibleForTesting annotation. Then you can invoke it in here.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, I have modified it to see if there are any other issues. I need to modify the visibility of getDocumentNumAndAvgSize if I use @VisibleForTesting, private doesn't work.
Hisoka-X
approved these changes
Apr 7, 2025
Hisoka-X
left a comment
Member
There was a problem hiding this comment.
LGTM if ci passes. Thanks @qifanlili
3 tasks
hailin0
approved these changes
Apr 7, 2025
qifanlili
added a commit
to qifanlili/seatunnel
that referenced
this pull request
Apr 14, 2025
author lee <liqifan@cvte.com> 1740121208 +0800 committer lee <liqifan@cvte.com> 1741076125 +0800 parent a3a7b49 author lee <liqifan@cvte.com> 1740121208 +0800 committer lee <liqifan@cvte.com> 1741076105 +0800 [Fix][MongoDB] The Long type cannot handle string values in scientific notation. (apache#8783)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
The purpose is to fix bug: 8775
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.