close
Skip to content

[Fix][Core] Fix --role parameter not working in seatunnel-cluster.cmd#8877

Merged
liunaijie merged 1 commit into
apache:devfrom
TongchengOpenSource:fix_window_role_param
Mar 3, 2025
Merged

[Fix][Core] Fix --role parameter not working in seatunnel-cluster.cmd#8877
liunaijie merged 1 commit into
apache:devfrom
TongchengOpenSource:fix_window_role_param

Conversation

@xiaochen-zhou

Copy link
Copy Markdown
Contributor

Purpose of this pull request

Fix --role parameter not working in seatunnel-cluster.cmd

Does this PR introduce any user-facing change?

no

How was this patch tested?

exists tests

Check list

@github-actions github-actions Bot added the core SeaTunnel core module label Feb 28, 2025

@davidzollo davidzollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

@liunaijie

Copy link
Copy Markdown
Member

Hi, this script has another issue #8226 (comment).
Do you want fix this?

@xiaochen-zhou

Copy link
Copy Markdown
Contributor Author

Hi, this script has another issue #8226 (comment). Do you want fix this?

I'm very sorry, but I'm not familiar with the scripting syntax for CMD in Windows, and I don't have a Windows environment to reproduce this issue.

@liunaijie liunaijie merged commit b5e5d00 into apache:dev Mar 3, 2025
@xiaochen-zhou xiaochen-zhou deleted the fix_window_role_param branch August 3, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved core SeaTunnel core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants