close
Skip to content

[Fix][Command] Run seatunnel on windows with fileAppender enabled, no log file been created#8938

Merged
Hisoka-X merged 2 commits into
apache:devfrom
FrommyMind:fix-8929
Mar 18, 2025
Merged

[Fix][Command] Run seatunnel on windows with fileAppender enabled, no log file been created#8938
Hisoka-X merged 2 commits into
apache:devfrom
FrommyMind:fix-8929

Conversation

@FrommyMind

Copy link
Copy Markdown
Contributor

Purpose of this pull request

Fix #8929

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

Tested on my local windows pc.
After enable fileAppender in log4j2_client.properties. client log have been created.

@github-actions github-actions Bot added the core SeaTunnel core module label Mar 8, 2025
@Hisoka-X

Copy link
Copy Markdown
Member

Could you help verify it? @hawk9821

hailin0
hailin0 previously approved these changes Mar 10, 2025

@hailin0 hailin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrommyMind

Copy link
Copy Markdown
Contributor Author

Update the logic of get filename. May fix this #8226 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved core SeaTunnel core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Command] Run seatunnel on windows with fileAppender enabled, no log file been created

3 participants