[Fix][Command] Run seatunnel on windows with fileAppender enabled, no log file been created#8938
Merged
Conversation
Member
|
Could you help verify it? @hawk9821 |
Contributor
Author
|
Update the logic of get filename. May fix this #8226 (comment) |
3 tasks
hailin0
approved these changes
Mar 15, 2025
Hisoka-X
approved these changes
Mar 18, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fix #8929
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list
New License Guide
release-note.Tested on my local windows pc.
After enable fileAppender in log4j2_client.properties. client log have been created.