close
Skip to content

[improve] http connector options#8969

Merged
hailin0 merged 8 commits into
apache:devfrom
liunaijie:improve/http_options
Mar 18, 2025
Merged

[improve] http connector options#8969
hailin0 merged 8 commits into
apache:devfrom
liunaijie:improve/http_options

Conversation

@liunaijie

Copy link
Copy Markdown
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list


@Slf4j
public class PrometheusSource extends HttpSource {

@liunaijie liunaijie Mar 12, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the Prometheus connector is also base on Http Connector.
Should we move this module to connector-http module as a sub module?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. We can do it with another PR. :)

@hailin0 hailin0 merged commit 63ff9f9 into apache:dev Mar 18, 2025
@liunaijie liunaijie deleted the improve/http_options branch March 25, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants