close
Skip to content

[Improve][Connector-V2][Http] Supports Cursor-based Pagination (#9109)#9138

Merged
hailin0 merged 11 commits into
apache:devfrom
Alberne:improve-connector-v2-http-cursor-base-pagination
Apr 15, 2025
Merged

[Improve][Connector-V2][Http] Supports Cursor-based Pagination (#9109)#9138
hailin0 merged 11 commits into
apache:devfrom
Alberne:improve-connector-v2-http-cursor-base-pagination

Conversation

@Alberne

@Alberne Alberne commented Apr 10, 2025 •
edited by Hisoka-X
Loading

Copy link
Copy Markdown
Contributor

Purpose of this pull request

close #9109

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0

hailin0 commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Please add e2e testcase

https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e

@github-actions github-actions Bot added the e2e label Apr 10, 2025
@Alberne

Alberne commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

Please add e2e testcase

https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e

added e2e test code completed, done~

TyrantLucifer
TyrantLucifer reviewed Apr 10, 2025
View reviewed changes
Comment thread ...e/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpSourceOptions.java Outdated
Comment thread ...e/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpSourceOptions.java Outdated
@Alberne Alberne requested a review from TyrantLucifer April 11, 2025 02:33
@Alberne

Alberne commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

@TyrantLucifer please review changes!

@Alberne Alberne requested a review from Hisoka-X April 14, 2025 01:51
Hisoka-X
Hisoka-X reviewed Apr 14, 2025
View reviewed changes
Comment thread docs/en/connector-v2/source/Http.md Outdated
Comment thread docs/en/connector-v2/source/Http.md
Comment thread .../src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpPaginationType.java Outdated
Comment thread ...se/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java Outdated
Comment thread ...nnel-connector-v2-e2e/connector-http-e2e/src/test/resources/http_page_cursor_num_assert.conf Outdated
@Alberne Alberne requested a review from Hisoka-X April 14, 2025 07:23
@Alberne

Alberne commented Apr 14, 2025

Copy link
Copy Markdown
Contributor Author

@Hisoka-X please review changes!

Hisoka-X
Hisoka-X reviewed Apr 15, 2025
View reviewed changes

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all doc and comment:
PageNumberPagination -> PageNumber
CursorPagination -> Cursor

Comment thread .../src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpPaginationType.java
Comment thread docs/en/connector-v2/source/Http.md Outdated
Comment thread docs/en/connector-v2/source/Http.md Outdated
Comment thread docs/en/connector-v2/source/Http.md Outdated
Comment thread docs/en/connector-v2/source/Http.md Outdated
Comment thread docs/en/connector-v2/source/Http.md Outdated
@Alberne Alberne requested a review from Hisoka-X April 15, 2025 03:13
@Alberne

Alberne commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

@Hisoka-X I have checked all the documentation and code snippets.

Hisoka-X
Hisoka-X approved these changes Apr 15, 2025
View reviewed changes

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @Alberne !

@hailin0 hailin0 merged commit 879b1e2 into apache:dev Apr 15, 2025
@Alberne Alberne deleted the improve-connector-v2-http-cursor-base-pagination branch April 18, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes
@Hisoka-X Hisoka-X Hisoka-X approved these changes
@TyrantLucifer TyrantLucifer Awaiting requested review from TyrantLucifer

Assignees

No one assigned

Labels

approved document e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Improve][Connector-V2][Http] Supports Cursor-based Pagination

4 participants

@Alberne @hailin0 @Hisoka-X @TyrantLucifer